Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-594] Remove entry prompt #12934

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[ENG-594] Remove entry prompt #12934

merged 2 commits into from
Oct 23, 2023

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Oct 23, 2023 •
edited by jira bot
Loading

Proposed changes:

  • fixes ENG-594
  • Remove EntryPromptFlowStep
  • Remove entry_prompt from yaml schema

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from a team as a code owner October 23, 2023 10:27
tmbo
tmbo approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure it also gets removed from the docs (not sure if we ever added it but worth to check)

@tabergma
Copy link
Contributor Author

@tmbo I could not find anything in the docs on the dm2 branch. Is there another docs repo that I should check?

@tmbo
Copy link
Member

tmbo commented Oct 23, 2023

yes, the docs are separate on the docs-dm2 branch #12795

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 54 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tabergma tabergma merged commit f71a675 into dm2 Oct 23, 2023
100 of 101 checks passed
@tabergma tabergma deleted the ENG-594-remove-entry-prompt branch October 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabergma @tmbo